Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1296753003: Cleanup CFX_UnicodeEncoding and remove IFX_FontEncoding. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup CFX_UnicodeEncoding and remove IFX_FontEncoding. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/52a48aadc19b2dee8abeb702269bb168eb6b6999

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -68 lines) Patch
M core/include/fxge/fx_font.h View 1 chunk +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 6 chunks +15 lines, -12 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 1 chunk +12 lines, -33 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
5 years, 4 months ago (2015-08-17 17:43:50 UTC) #2
Tom Sepez
lgtm
5 years, 4 months ago (2015-08-17 18:39:49 UTC) #3
Lei Zhang
5 years, 4 months ago (2015-08-17 22:05:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
52a48aadc19b2dee8abeb702269bb168eb6b6999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698