Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1296733002: DevTools: roll Codemirror JavaScript Mode to @7c3fb5cc (Closed)

Created:
5 years, 4 months ago by lushnikov
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: roll Codemirror JavaScript Mode to @7c3fb5cc This patch rolls CodeMirror javaScirpt mode to the latest @7c3fb566 (tip-of-tree) version. The new javascript mode will fix troubles with highlighting unicode variables. BUG=520521 TBR=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M Source/devtools/front_end/cm/javascript.js View 18 chunks +38 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
lushnikov
ptal
5 years, 4 months ago (2015-08-14 23:07:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296733002/1
5 years, 4 months ago (2015-08-15 00:49:18 UTC) #3
pfeldman
lgtm
5 years, 4 months ago (2015-08-15 00:55:34 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 01:54:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200589

Powered by Google App Engine
This is Rietveld 408576698