Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129673002: Use StringBuilder::append instead of String::append (Closed)

Created:
6 years, 11 months ago by maheshkk
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@touch_icon
Visibility:
Public.

Description

Use StringBuilder::append instead of String::append BUG=268281 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maheshkk
Trying to remove String::append usage from WebGLRenderingContext.
6 years, 11 months ago (2014-01-08 22:38:43 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-08 23:20:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/129673002/1
6 years, 11 months ago (2014-01-08 23:20:40 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 03:46:00 UTC) #4
Message was sent while issue was closed. 
Change committed as 164738

Powered by Google App Engine
This is Rietveld 408576698