Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: lib/src/info.dart

Issue 1296723002: Cleanup InferableOverride (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Fix format Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/checker.dart ('k') | test/checker/checker_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/info.dart
diff --git a/lib/src/info.dart b/lib/src/info.dart
index 03c158764415017e97807b8556376fc4e9b63b0f..228a0fc426bad80ce68608c674090acdef16d013 100644
--- a/lib/src/info.dart
+++ b/lib/src/info.dart
@@ -527,18 +527,6 @@ class InvalidMethodOverride extends InvalidOverride {
String get message => _messageHelper('Invalid override');
}
-// TODO(sigmund): delete, if we fix this, this should be part of the type
-// inference, not something we detect in the checker.
-// TODO(sigmund): split and track field, getter, setter, method separately
-class InferableOverride extends InvalidOverride {
- InferableOverride(AstNode node, ExecutableElement element, InterfaceType base,
- DartType subType, DartType baseType)
- : super(node, element, base, subType, baseType);
-
- toErrorCode() => new CompileTimeErrorCode(name, message);
- String get message => _messageHelper('Invalid but inferable override');
-}
-
/// Used to mark unexpected situations in our compiler were we couldn't compute
/// the type of an expression.
// TODO(sigmund): This is normally a result of another error that is caught by
« no previous file with comments | « lib/src/checker/checker.dart ('k') | test/checker/checker_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698