Cleanup InferableOverride

lib/src/checker/checker.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.checker.checker;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/scanner.dart' show Token, TokenType;
@@ skipping 277 matching lines @@
       //
       // Common pattern 1: Inferable return type (on getters and methods)
       //   class A {
       //     int get foo => ...;
       //     String toString() { ... }
       //   }
       //   class B extends A {
       //     get foo => e; // no type specified.
       //     toString() { ... } // no return type specified.
       //   }
-      if (_isInferableOverride(element, node, subType, baseType)) {
-        _recordMessage(new InferableOverride(errorLocation, element, type,
-            subType.returnType, baseType.returnType));
-      } else {
-        _recordMessage(new InvalidMethodOverride(
-            errorLocation, element, type, subType, baseType));
-      }
+      _recordMessage(new InvalidMethodOverride(
+          errorLocation, element, type, subType, baseType));
     }
     return true;
   }
 
-  bool _isInferableOverride(ExecutableElement element, AstNode node,
-      FunctionType subType, FunctionType baseType) {
-    if (_inferFromOverrides || node == null) return false;
-    final isGetter = element is PropertyAccessorElement && element.isGetter;
-    if (isGetter && element.isSynthetic) {
-      var field = node.parent.parent;
-      return field is FieldDeclaration && field.fields.type == null;
-    }
-
-    // node is a MethodDeclaration whenever getters and setters are
-    // declared explicitly. Setters declared from a field will have the
-    // correct return type, so we don't need to check that separately.
-    return node is MethodDeclaration &&
-        node.returnType == null &&
-        _rules.isFunctionSubTypeOf(subType, baseType, ignoreReturn: true);
-  }
-
   void _recordMessage(StaticInfo info) {
     if (info == null) return;
     var error = info.toAnalysisError();
     if (error.errorCode.errorSeverity == ErrorSeverity.ERROR) _failure = true;
     _reporter.onError(error);
   }
 }
 
 /// Checks the body of functions and properties.
 class CodeChecker extends RecursiveAstVisitor {
@@ skipping 604 matching lines @@
     if (info is CoercionInfo) {
       // TODO(jmesserly): if we're run again on the same AST, we'll produce the
       // same annotations. This should be harmless. This might go away once
       // CodeChecker is integrated better with analyzer, as it will know that
       // checking has already been performed.
       // assert(CoercionInfo.get(info.node) == null);
       CoercionInfo.set(info.node, info);
     }
   }
 }