chrome/browser/component_updater/test/component_updater_service_unittest.cc - Issue 12967016: Improve <adview> implementation and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/test/component_updater_service_unittest.cc

Issue 12967016: Improve <adview> implementation and add tests. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Code review feedback. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/component_updater/test/component_updater_service_unittest.cc

diff --git a/chrome/browser/component_updater/test/component_updater_service_unittest.cc b/chrome/browser/component_updater/test/component_updater_service_unittest.cc

index 471c90a2a98daeeda832c9b595708d1a18c4eb2f..edcedc8641e29b804ca17e1ed189842075cc482e 100644

--- a/chrome/browser/component_updater/test/component_updater_service_unittest.cc

+++ b/chrome/browser/component_updater/test/component_updater_service_unittest.cc

@@ -294,7 +294,7 @@ TEST_F(ComponentUpdaterTest, CheckCrxSleep) {

io_thread.StartIOThread();

file_thread.Start();

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

CrxComponent com;

RegisterComponent(&com, kTestComponent_abag, Version("1.1"));

@@ -372,7 +372,7 @@ TEST_F(ComponentUpdaterTest, InstallCrx) {

io_thread.StartIOThread();

file_thread.Start();

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

CrxComponent com1;

RegisterComponent(&com1, kTestComponent_jebg, Version("0.9"));

@@ -437,7 +437,7 @@ TEST_F(ComponentUpdaterTest, InstallCrxTwoSources) {

io_thread.StartIOThread();

file_thread.Start();

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

CrxComponent com1;

RegisterComponent(&com1, kTestComponent_abag, Version("2.2"));

@@ -509,7 +509,7 @@ TEST_F(ComponentUpdaterTest, ProdVersionCheck) {

io_thread.StartIOThread();

file_thread.Start();

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

CrxComponent com;

RegisterComponent(&com, kTestComponent_jebg, Version("0.9"));

@@ -549,7 +549,7 @@ TEST_F(ComponentUpdaterTest, CheckForUpdateSoon) {

io_thread.StartIOThread();

file_thread.Start();

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

CrxComponent com1;

RegisterComponent(&com1, kTestComponent_abag, Version("2.2"));

« no previous file with comments | « no previous file | chrome/browser/extensions/ad_view_browsertest.cc » ('j') | chrome/renderer/resources/extensions/ad_view.js » ('J')