chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/manifest.json - Issue 12967016: Improve <adview> implementation and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/manifest.json

Issue 12967016: Improve <adview> implementation and add tests. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Code review feedback. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/chrometest.js ('K') | « chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/main.js ('k') | content/test/net/url_request_prepackaged_interceptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/manifest.json

diff --git a/chrome/test/data/extensions/platform_apps/ad_view/load_event/manifest.json b/chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/manifest.json

similarity index 88%

rename from chrome/test/data/extensions/platform_apps/ad_view/load_event/manifest.json

rename to chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/manifest.json

index 8d706882b73107a1c1ffe09f713eb8260b9aef28..cb453051a2582bbefac73c26a72300d9bf61c20b 100644

--- a/chrome/test/data/extensions/platform_apps/ad_view/load_event/manifest.json

+++ b/chrome/test/data/extensions/platform_apps/ad_view/src_not_exposed/manifest.json

@@ -9,6 +9,6 @@

}

"permissions": [

- "adview"

+ "adview", "webview"

benwells 2013/04/03 02:40:03 why is webview permission needed?

rpaquay 2013/04/03 18:30:05 This is a mistake, this should not have been there

]