Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4104)

Unified Diff: cc/layers/heads_up_display_layer_impl.cc

Issue 1296673004: Devtools/CC: Remove continuous repainting feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/heads_up_display_layer_impl.cc
diff --git a/cc/layers/heads_up_display_layer_impl.cc b/cc/layers/heads_up_display_layer_impl.cc
index ad3522e3e62036927e6b02e4ac1ff72f72191b4a..59257b45efb3451c7fa8461bdeea89a7426b0ce1 100644
--- a/cc/layers/heads_up_display_layer_impl.cc
+++ b/cc/layers/heads_up_display_layer_impl.cc
@@ -245,20 +245,6 @@ void HeadsUpDisplayLayerImpl::UpdateHudContents() {
fps_counter->GetMinAndMaxFPS(&fps_graph_.min, &fps_graph_.max);
}
- if (debug_state.continuous_painting) {
- PaintTimeCounter* paint_time_counter =
- layer_tree_impl()->paint_time_counter();
- base::TimeDelta latest, min, max;
-
- if (paint_time_counter->End())
- latest = **paint_time_counter->End();
- paint_time_counter->GetMinAndMaxPaintTime(&min, &max);
-
- paint_time_graph_.value = latest.InMillisecondsF();
- paint_time_graph_.min = min.InMillisecondsF();
- paint_time_graph_.max = max.InMillisecondsF();
- }
-
if (debug_state.ShowMemoryStats()) {
MemoryHistory* memory_history = layer_tree_impl()->memory_history();
if (memory_history->End())
@@ -283,17 +269,14 @@ void HeadsUpDisplayLayerImpl::DrawHudContents(SkCanvas* canvas) {
}
SkRect area = SkRect::MakeEmpty();
- if (debug_state.continuous_painting) {
- area = DrawPaintTimeDisplay(
- canvas, layer_tree_impl()->paint_time_counter(), 0, 0);
- } else if (debug_state.show_fps_counter) {
+ if (debug_state.show_fps_counter) {
danakj 2015/08/21 18:56:09 you can just early out if !show_fps_counter and do
samli 2015/08/26 21:08:24 Done.
// Don't show the FPS display when continuous painting is enabled, because
danakj 2015/08/21 18:56:09 This comment should go
samli 2015/08/26 21:08:24 Done.
// it would show misleading numbers.
area =
DrawFPSDisplay(canvas, layer_tree_impl()->frame_rate_counter(), 0, 0);
}
- if (debug_state.show_fps_counter || debug_state.continuous_painting) {
+ if (debug_state.show_fps_counter) {
area = DrawGpuRasterizationStatus(canvas, 0, area.bottom(),
SkMaxScalar(area.width(), 150));
}

Powered by Google App Engine
This is Rietveld 408576698