Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/proxy_config.gypi

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated gn build Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/proxy_config/BUILD.gn » ('j') | components/proxy_config/pref_proxy_config_tracker_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/proxy_config.gypi
diff --git a/components/proxy_config.gypi b/components/proxy_config.gypi
index a6926f9b4546eb1e77e589fa3c90a7be3376ff32..a8c074cad3c45cd226d10e941464d7761029f7a2 100644
--- a/components/proxy_config.gypi
+++ b/components/proxy_config.gypi
@@ -10,6 +10,7 @@
'type': '<(component)',
'dependencies': [
'../base/base.gyp:base',
+ '../components.gyp:pref_registry',
droger 2015/08/19 09:30:53 This should be simply: 'pref_registry',
Abhishek 2015/08/19 10:10:29 Done.
'../net/net.gyp:net',
],
'include_dirs': [
@@ -19,9 +20,15 @@
'PROXY_CONFIG_IMPLEMENTATION',
],
'sources': [
+ 'proxy_config/pref_proxy_config_tracker.cc',
+ 'proxy_config/pref_proxy_config_tracker.h',
+ 'proxy_config/pref_proxy_config_tracker_impl.cc',
+ 'proxy_config/pref_proxy_config_tracker_impl.h',
'proxy_config/proxy_config_dictionary.cc',
'proxy_config/proxy_config_dictionary.h',
'proxy_config/proxy_config_export.h',
+ 'proxy_config/proxy_config_pref_names.cc',
+ 'proxy_config/proxy_config_pref_names.h',
'proxy_config/proxy_prefs.cc',
'proxy_config/proxy_prefs.h',
],
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/proxy_config/BUILD.gn » ('j') | components/proxy_config/pref_proxy_config_tracker_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698