Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: chrome/browser/prefs/command_line_pref_store.cc

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updating for win p/f Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/prefs/command_line_pref_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/command_line_pref_store.cc
diff --git a/chrome/browser/prefs/command_line_pref_store.cc b/chrome/browser/prefs/command_line_pref_store.cc
index 8e0cab281d6734a78b56128766766bd8764ec14c..b06fd163f1d02c0fa8405f1009785d3151c61904 100644
--- a/chrome/browser/prefs/command_line_pref_store.cc
+++ b/chrome/browser/prefs/command_line_pref_store.cc
@@ -15,6 +15,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/proxy_config/proxy_config_dictionary.h"
+#include "components/proxy_config/proxy_config_pref_names.h"
#include "ui/base/ui_base_switches.h"
#if defined(OS_CHROMEOS)
@@ -148,18 +149,18 @@ void CommandLinePrefStore::ApplySimpleSwitches() {
void CommandLinePrefStore::ApplyProxyMode() {
if (command_line_->HasSwitch(switches::kNoProxyServer)) {
- SetValue(prefs::kProxy,
+ SetValue(proxy_config::prefs::kProxy,
make_scoped_ptr(ProxyConfigDictionary::CreateDirect()),
WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
} else if (command_line_->HasSwitch(switches::kProxyPacUrl)) {
std::string pac_script_url =
command_line_->GetSwitchValueASCII(switches::kProxyPacUrl);
- SetValue(prefs::kProxy,
+ SetValue(proxy_config::prefs::kProxy,
make_scoped_ptr(
ProxyConfigDictionary::CreatePacScript(pac_script_url, false)),
WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
} else if (command_line_->HasSwitch(switches::kProxyAutoDetect)) {
- SetValue(prefs::kProxy,
+ SetValue(proxy_config::prefs::kProxy,
make_scoped_ptr(ProxyConfigDictionary::CreateAutoDetect()),
WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
} else if (command_line_->HasSwitch(switches::kProxyServer)) {
@@ -167,7 +168,7 @@ void CommandLinePrefStore::ApplyProxyMode() {
command_line_->GetSwitchValueASCII(switches::kProxyServer);
std::string bypass_list =
command_line_->GetSwitchValueASCII(switches::kProxyBypassList);
- SetValue(prefs::kProxy,
+ SetValue(proxy_config::prefs::kProxy,
make_scoped_ptr(ProxyConfigDictionary::CreateFixedServers(
proxy_server, bypass_list)),
WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/prefs/command_line_pref_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698