Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5454)

Unified Diff: chrome/browser/extensions/api/proxy/proxy_apitest.cc

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updating for win p/f Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/proxy/proxy_apitest.cc
diff --git a/chrome/browser/extensions/api/proxy/proxy_apitest.cc b/chrome/browser/extensions/api/proxy/proxy_apitest.cc
index bd8041288e1930fd487e5a83e1546e0acd67e884..740efa54e8567c8561441bf8901281dadac018b0 100644
--- a/chrome/browser/extensions/api/proxy/proxy_apitest.cc
+++ b/chrome/browser/extensions/api/proxy/proxy_apitest.cc
@@ -8,8 +8,8 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome/common/pref_names.h"
#include "components/proxy_config/proxy_config_dictionary.h"
+#include "components/proxy_config/proxy_config_pref_names.h"
#include "extensions/common/extension.h"
#include "extensions/test/result_catcher.h"
@@ -31,11 +31,12 @@ class ProxySettingsApiTest : public ExtensionApiTest {
const std::string& expected_pac_url,
PrefService* pref_service) {
const PrefService::Preference* pref =
- pref_service->FindPreference(prefs::kProxy);
+ pref_service->FindPreference(proxy_config::prefs::kProxy);
ASSERT_TRUE(pref != NULL);
EXPECT_TRUE(pref->IsExtensionControlled());
- ProxyConfigDictionary dict(pref_service->GetDictionary(prefs::kProxy));
+ ProxyConfigDictionary dict(
+ pref_service->GetDictionary(proxy_config::prefs::kProxy));
ProxyPrefs::ProxyMode mode;
ASSERT_TRUE(dict.GetMode(&mode));
@@ -66,7 +67,7 @@ class ProxySettingsApiTest : public ExtensionApiTest {
void ExpectNoSettings(PrefService* pref_service) {
const PrefService::Preference* pref =
- pref_service->FindPreference(prefs::kProxy);
+ pref_service->FindPreference(proxy_config::prefs::kProxy);
ASSERT_TRUE(pref != NULL);
EXPECT_FALSE(pref->IsExtensionControlled());
}

Powered by Google App Engine
This is Rietveld 408576698