chrome/browser/extensions/extension_message_bubble_controller_unittest.cc - Issue 1296663003: Componentize proxy code from chrome/browser/net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated build errors Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/extensions/settings_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

index b35baaead3eed6ce69337aac7486d15bd5db88c1..5fd1474387002e1f2c65aa0c0dd38ff6258aa58f 100644

--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

@@ -19,6 +19,7 @@

#include "chrome/common/pref_names.h"

stevenjb 2015/08/19 15:44:46 Still needed?

Abhishek 2015/08/20 14:14:50 Done.

#include "chrome/test/base/browser_with_test_window_test.h"

#include "chrome/test/base/testing_profile.h"

+#include "components/proxy_config/proxy_config_pref_names.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "extensions/browser/api_test_utils.h"

#include "extensions/browser/extension_pref_value_map.h"

@@ -367,8 +368,7 @@ class ExtensionMessageBubbleTest : public BrowserWithTestWindowTest {

base::Time::Now(),

true, // is_enabled.

false); // is_incognito_enabled.

- extension_prefs_value_map->SetExtensionPref(id,

- prefs::kProxy,

+ extension_prefs_value_map->SetExtensionPref(id, ProxyPrefs::prefs::kProxy,

kExtensionPrefsScopeRegular,

new base::StringValue(id));

« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/extensions/settings_api_helpers.cc » ('j') | no next file with comments »