Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: chrome/browser/net/proxy_policy_handler_unittest.cc

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/proxy_policy_handler_unittest.cc
diff --git a/chrome/browser/net/proxy_policy_handler_unittest.cc b/chrome/browser/net/proxy_policy_handler_unittest.cc
index 8e2737ff47f1667cdb8e506b992daaec7ef71ed5..b3447e06880edd70b9429ef955929b7cd54805ff 100644
--- a/chrome/browser/net/proxy_policy_handler_unittest.cc
+++ b/chrome/browser/net/proxy_policy_handler_unittest.cc
@@ -43,7 +43,7 @@ class ProxyPolicyHandlerTest
const std::string& expected_proxy_bypass_list,
const ProxyPrefs::ProxyMode& expected_proxy_mode) {
const base::Value* value = NULL;
- ASSERT_TRUE(store_->GetValue(prefs::kProxy, &value));
+ ASSERT_TRUE(store_->GetValue(ProxyPrefs::kProxy, &value));
ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
ProxyConfigDictionary dict(
static_cast<const base::DictionaryValue*>(value));
@@ -138,7 +138,7 @@ TEST_F(ProxyPolicyHandlerTest, ManualOptionsInvalid) {
UpdateProviderPolicy(policy);
const base::Value* value = NULL;
- EXPECT_FALSE(store_->GetValue(prefs::kProxy, &value));
+ EXPECT_FALSE(store_->GetValue(ProxyPrefs::kProxy, &value));
}
TEST_F(ProxyPolicyHandlerTest, NoProxyServerMode) {
@@ -222,7 +222,7 @@ TEST_F(ProxyPolicyHandlerTest, PacScriptProxyModeInvalid) {
NULL);
UpdateProviderPolicy(policy);
const base::Value* value = NULL;
- EXPECT_FALSE(store_->GetValue(prefs::kProxy, &value));
+ EXPECT_FALSE(store_->GetValue(ProxyPrefs::kProxy, &value));
}
// Regression test for http://crbug.com/78016, CPanel returns empty strings
@@ -322,7 +322,7 @@ TEST_F(ProxyPolicyHandlerTest, ProxyInvalid) {
NULL);
UpdateProviderPolicy(policy);
const base::Value* value = NULL;
- EXPECT_FALSE(store_->GetValue(prefs::kProxy, &value));
+ EXPECT_FALSE(store_->GetValue(ProxyPrefs::kProxy, &value));
}
}

Powered by Google App Engine
This is Rietveld 408576698