Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: pkg/analyzer/lib/source/sdk_ext.dart

Issue 1296653003: Fix most implementations of UriResolver.restoreAbsolute. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/file_system/file_system.dart ('k') | pkg/analyzer/lib/src/generated/source.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/source/sdk_ext.dart
diff --git a/pkg/analyzer/lib/source/sdk_ext.dart b/pkg/analyzer/lib/source/sdk_ext.dart
index 7caad4359c4ef100b357fa9c7f2315a3a0e7a1fa..6cd358f8f17b9507cd44fcdbe076fc58943781ca 100644
--- a/pkg/analyzer/lib/source/sdk_ext.dart
+++ b/pkg/analyzer/lib/source/sdk_ext.dart
@@ -76,6 +76,8 @@ class SdkExtUriResolver extends UriResolver {
@override
Uri restoreAbsolute(Source source) {
+ // TODO(paulberry, johnmccutchan): this has incorrect semantics because it
+ // refers to source.uri. See dartbug.com/24090.
String libraryName = _libraryName(source.uri);
if (_registeredSdkExtension(libraryName)) {
return source.uri;
« no previous file with comments | « pkg/analyzer/lib/file_system/file_system.dart ('k') | pkg/analyzer/lib/src/generated/source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698