Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296543003: Use transposedSize in more places (Closed)

Created:
5 years, 4 months ago by rwlbuis
Modified:
5 years, 4 months ago
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use transposedSize in more places Using this method makes the code intent more clear. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200667

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove transposedRect change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/graphics/BitmapImage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageSource.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL.
5 years, 4 months ago (2015-08-14 21:06:45 UTC) #2
leviw_travelin_and_unemployed
https://codereview.chromium.org/1296543003/diff/1/Source/platform/graphics/BitmapImage.cpp File Source/platform/graphics/BitmapImage.cpp (left): https://codereview.chromium.org/1296543003/diff/1/Source/platform/graphics/BitmapImage.cpp#oldcode301 Source/platform/graphics/BitmapImage.cpp:301: adjustedDstRect = FloatRect(adjustedDstRect.x(), adjustedDstRect.y(), adjustedDstRect.height(), adjustedDstRect.width()); The old code ...
5 years, 4 months ago (2015-08-14 22:34:14 UTC) #3
rwlbuis
On 2015/08/14 22:34:14, leviw wrote: > https://codereview.chromium.org/1296543003/diff/1/Source/platform/graphics/BitmapImage.cpp > File Source/platform/graphics/BitmapImage.cpp (left): > > https://codereview.chromium.org/1296543003/diff/1/Source/platform/graphics/BitmapImage.cpp#oldcode301 > ...
5 years, 4 months ago (2015-08-17 16:58:44 UTC) #4
leviw_travelin_and_unemployed
lgtm
5 years, 4 months ago (2015-08-17 19:42:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296543003/20001
5 years, 4 months ago (2015-08-17 19:43:15 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 21:11:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200667

Powered by Google App Engine
This is Rietveld 408576698