Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 12965013: Make Isolate::GetHeapStatistics robust against half-initialized isolates. (Closed)

Created:
7 years, 9 months ago by marja
Modified:
7 years, 9 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Make Isolate::GetHeapStatistics robust against half-initialized isolates. The (deprecated) non-Isolate GetHeapStatistics contains the same check. BUG=2591 Committed: https://code.google.com/p/v8/source/detail?r=14079

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code review (hpayer) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/api.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
payer
LGTM with one nit https://codereview.chromium.org/12965013/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/12965013/diff/1/src/api.cc#newcode5975 src/api.cc:5975: // Isolate is unitialized thus ...
7 years, 9 months ago (2013-03-27 10:23:52 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 9 months ago (2013-03-27 10:33:15 UTC) #2
Hannes Payer (out of office)
7 years, 9 months ago (2013-03-27 10:33:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698