Issue 12965013: Make Isolate::GetHeapStatistics robust against half-initialized isolates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12965013: Make Isolate::GetHeapStatistics robust against half-initialized isolates. (Closed)

Created:
7 years, 9 months ago by marja

Modified:
7 years, 9 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Make Isolate::GetHeapStatistics robust against half-initialized isolates. The (deprecated) non-Isolate GetHeapStatistics contains the same check. BUG=2591 Committed: https://code.google.com/p/v8/source/detail?r=14079

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code review (hpayer) #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/api.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

payer

LGTM with one nit https://codereview.chromium.org/12965013/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/12965013/diff/1/src/api.cc#newcode5975 src/api.cc:5975: // Isolate is unitialized thus ...

7 years, 9 months ago (2013-03-27 10:23:52 UTC) #1

Hannes Payer (out of office)

7 years, 9 months ago (2013-03-27 10:33:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14079 (presubmit successful).

Expand Messages | Collapse Messages