Split the libpeerconnection target up in two parts. The new target, libjingle_webrtc contains all t…

Split the libpeerconnection target up in two parts. The new target, libjingle_webrtc contains all the webrtc parts except for the media engine implementation. The media engine implementation stays in libpeerconnection and will be built as a shared library when component==shared_library. Since libjingle_webrtc contains the code that depends on libpeerconnection, those targets that previously only depended on libpeerconnection have been updated to include on libjingle_webrtc as well.

TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190391

[tommi (sloooow) - chröme, 2013-03-25 12:16:15]

ronghua: libjingle.gyp
darin: *.gypi

[Mallinath (Gone from Chromium), 2013-03-25 13:52:37]

I have one question, otherwise its lgtm.

https://codereview.chromium.org/12965010/diff/1/third_party/libjingle/libjing...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12965010/diff/1/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:842: 'libjingle_webrtc',
What about libjingle dependency on the left side?

[tommi (sloooow) - chröme, 2013-03-25 13:59:28]

https://codereview.chromium.org/12965010/diff/1/third_party/libjingle/libjing...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12965010/diff/1/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:842: 'libjingle_webrtc',
On 2013/03/25 13:52:37, mallinath2 wrote:
> What about libjingle dependency on the left side?

If I'm understanding you correctly, then libjingle dependencies are pulled in
via libjingle_webrtc.

[tommi (sloooow) - chröme, 2013-03-25 14:03:10]

I'm going to try to land this as is and watch the tree since we're in the off
hours still.  There  were issues with two of the linux bots on the waterfall
over the weekend that I have not been able to repro with either trybots or on my
machines.  I'm hoping that this will address the issue.

[tommi (sloooow) - chröme, 2013-03-25 14:05:02]

Committed patchset #1 manually as r190391 (presubmit successful).

[Mallinath (Gone from Chromium), 2013-03-25 14:32:47]

lgtm