Move chrome/browser/chromeos/drive/resource* (+deps) into components/drive.

Move chrome/browser/chromeos/drive/resource* (+deps) into components/drive.

Files moved from chrome/browser/chromeos/drive into components/drive:
- fake_free_disk_space_getter*
- file_cache*
- file_system_core_util*
- resource_entry_conversion*
- resource_metadata*
- resource_metadata_storage*

Other changes:
- Removed unneeded includes where needed and possible.
- Hidden usage of cryptohome::kMinFreeSpaceInBytes behind OS_CHROMEOS ifdefs
  and provided an equivalent constant shared by other OS-es.
- Hidden usage of base::SetPosixFilePermissions behind OS_CHROMEOS ifdef
  as it was only needed to support cros_disks service on ChromeOS.
- Moved 3 functions back from file_system_core_util into file_system_core.
  The 3 functions are ChromeOS-specific (dealing with where GDrive is mounted
  on ChromeOS) and moving them back helps avoid adding a new dependency on
  components/drive from chromeos directories.
- When adding a third_party/leveldatabase dependency to gyp/gn/deps files
  under components/drive, I realized that gn is not consistent with gyp, by
  not explicitly listing a dependency on third_party/cacheinvalidation in
  components/drive/BUILD.gn.

Test steps:
1. Verify that things still build via GYP (and unit tests pass).
   $ GYP_DEFINES="use_goma=1 gomadir=... chromeos=1" gclient sync
   $ ninja -C out/Debug -j 150 chrome unit_tests \
         interactive_ui_tests browser_tests drive
   $ out/Debug/unit_tests

2. Verify that things still build via GN.
    $ gn gen out/Default --args='target_os="chromeos" use_goma=true'
    $ ninja -C out/Default -j 150 chrome unit_tests \
          interactive_ui_tests browser_tests components/drive

TEST=Please see "Test steps" above.
BUG=257943, 498951
TBR=mtomasz@chromium.org, satorux@chromium.org, phajdan.jr@chromium.org, rockot@chromium.org, stevenjb@chromium.org,

Committed: https://crrev.com/6364a0299330a1ac060f0794f4638f82c0dc5cc2
Cr-Commit-Position: refs/heads/master@{#344637}

[Łukasz Anforowicz, 2015-08-14 00:06:34]

lukasza@chromium.org changed reviewers:
+ hashimoto@chromium.org

[Łukasz Anforowicz, 2015-08-14 00:06:35]

Ryo, could you please take a look?

[hashimoto, 2015-08-14 00:47:54]

lgtm

https://codereview.chromium.org/1296483003/diff/1/components/drive/file_syste...
File components/drive/file_system_core_util.h (right):

https://codereview.chromium.org/1296483003/diff/1/components/drive/file_syste...
components/drive/file_system_core_util.h:6: #define
COMPONENTS_DRIVE_FILE_SYSTEM_CORE_UTIL_H_
nit: How about naming this file components/drive/file_system_util.h?
Now this file is the only "file_system_util" in the directory so it seems there
is no need to have "core" in the name.

The same goes for file_system_core_util.cc and
file_system_core_util_unittest.cc.

[Łukasz Anforowicz, 2015-08-14 17:14:44]

lukasza@chromium.org changed reviewers:
+ jsbell@chromium.org

[Łukasz Anforowicz, 2015-08-14 17:14:45]

Thanks Ryo.

Joshua - could you please review the dependency from components/drive into
third_party/leveldatabase (this is an old dependency that has already existed
before in code that we are moving from chrome/browser/chromeos/drive into
components/drive).

https://codereview.chromium.org/1296483003/diff/1/components/drive/file_syste...
File components/drive/file_system_core_util.h (right):

https://codereview.chromium.org/1296483003/diff/1/components/drive/file_syste...
components/drive/file_system_core_util.h:6: #define
COMPONENTS_DRIVE_FILE_SYSTEM_CORE_UTIL_H_
On 2015/08/14 00:47:54, hashimoto wrote:
> nit: How about naming this file components/drive/file_system_util.h?
> Now this file is the only "file_system_util" in the directory so it seems
there
> is no need to have "core" in the name.
> 
> The same goes for file_system_core_util.cc and
> file_system_core_util_unittest.cc.

Done.

[Łukasz Anforowicz, 2015-08-14 17:26:57]

lukasza@chromium.org changed reviewers:
+ mtomasz@chromium.org, phajdan.jr@chromium.org, rockot@chromium.org,
satorux@chromium.org, stevenjb@chromium.org

[Łukasz Anforowicz, 2015-08-14 17:26:58]

Tomasz, Satoru, Pawel, Ken, Steven,

I've added you as TBR, because I believe changes I am making in your directories
are mechanical (and therefore TBR should be sufficient).

In particular - changes in
- chrome/browser/chromeos/extensions/file_manager/job_event_router.cc
- chrome/browser/chromeos/file_manager/...
- chrome/browser/chromeos/fileapi/...
- chrome/browser/chromeos/preferences.cc
- chrome/browser/download/...
- chrome/browser/extensions/webstore_installer.cc
- chrome/browser/ui/ash/chrome_screenshot_grabber.cc
are mechanical changes of include paths caused by either
- Move of source files from chrome/browser/chromeos/drive into components/drive
or
- Move of 3 functions from
  chrome/browser/chromeos/drive/file_system_core_util.h
  (new location: components/drive/file_system_util.h)
  into chrome/browser/chromeos/drive/file_system_util.h

[jsbell, 2015-08-17 16:42:32]

DEPS into third_party/leveldatabase lgtm

[Łukasz Anforowicz, 2015-08-17 16:50:29]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2015-08-17 16:50:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
hashimoto@chromium.org, jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/1296483003/#ps40001
(title: "Rebasing...")

[commit-bot: I haz the power, 2015-08-17 16:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1296483003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1296483003/40001

[commit-bot: I haz the power, 2015-08-17 17:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-17 17:00:37]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2015-08-17 18:32:39]

On 2015/08/17 17:00:37, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

This build failure is caused by having the same filename
(file_system_util_unittest.cc) in different directories, but same GN source set.
 I should have re-run GN test steps, not just GYP test steps after snapshot #2.

I am trying to fix this problem in a separate CL (crrev.com/1296273002 - not yet
ready to land - I am still going through test steps from cl description).  I'll
put the current CL (crrev.com/1296483003) on hold, until the other CL
(crrev.com/1296273002) lands.

[Łukasz Anforowicz, 2015-08-19 19:12:29]

Ryo - I just wanted to give you a heads-up that I need to revert the renaming of
file_system_core_util - see the inline comment for more details.

https://codereview.chromium.org/1296483003/diff/1/components/drive/file_syste...
File components/drive/file_system_core_util.h (right):

https://codereview.chromium.org/1296483003/diff/1/components/drive/file_syste...
components/drive/file_system_core_util.h:6: #define
COMPONENTS_DRIVE_FILE_SYSTEM_CORE_UTIL_H_
On 2015/08/14 17:14:45, Łukasz Anforowicz wrote:
> On 2015/08/14 00:47:54, hashimoto wrote:
> > nit: How about naming this file components/drive/file_system_util.h?
> > Now this file is the only "file_system_util" in the directory so it seems
> there
> > is no need to have "core" in the name.
> > 
> > The same goes for file_system_core_util.cc and
> > file_system_core_util_unittest.cc.
> 
> Done.

Actually, I need to undo this renaming, because 1) it leads to a GN error [1,2]
about duplicate basenames and 2) there is no easy workaround [3].  Since this
was only a "nit", I assume that this is ok / doesn't need re-review (and in case
we still want to do it going forward, we can always do it in a separate CL.

[1]
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
[2]
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
[3]
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/SnyltwzSoaU/dis...

[Łukasz Anforowicz, 2015-08-19 19:14:08]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2015-08-19 19:14:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
hashimoto@chromium.org, jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/1296483003/#ps80001
(title: "Rebasing...")

[commit-bot: I haz the power, 2015-08-19 19:14:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1296483003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1296483003/80001

[commit-bot: I haz the power, 2015-08-19 19:53:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 19:53:07]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Łukasz Anforowicz, 2015-08-19 20:19:13]

Ryo, I think the latest patchset requires a re-review from you please (need to
skip SetPosixFilePermissions on non-POSIX targets in file_cache.cc -
https://codereview.chromium.org/1296483003/diff2/80001:100001/components/driv...).

[hashimoto, 2015-08-20 05:34:45]

still lgtm

https://codereview.chromium.org/1296483003/diff/100001/components/drive/file_...
File components/drive/file_cache.cc (right):

https://codereview.chromium.org/1296483003/diff/100001/components/drive/file_...
components/drive/file_cache.cc:249: #if defined(OS_POSIX)
nit: Probably OS_CHROMEOS is better.
cros_disks is a service which is available only on Chrome OS.

[Łukasz Anforowicz, 2015-08-20 19:00:27]

https://codereview.chromium.org/1296483003/diff/100001/components/drive/file_...
File components/drive/file_cache.cc (right):

https://codereview.chromium.org/1296483003/diff/100001/components/drive/file_...
components/drive/file_cache.cc:249: #if defined(OS_POSIX)
On 2015/08/20 05:34:45, hashimoto wrote:
> nit: Probably OS_CHROMEOS is better.
> cros_disks is a service which is available only on Chrome OS.

Done.  Thanks for pointing this out.

[Łukasz Anforowicz, 2015-08-20 22:16:54]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2015-08-20 22:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org,
hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1296483003/#ps140001
(title: "Rebasing...")

[commit-bot: I haz the power, 2015-08-20 22:17:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1296483003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1296483003/140001

[commit-bot: I haz the power, 2015-08-21 01:13:35]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-08-21 01:14:15]

Patchset 8 (id:??) landed as
https://crrev.com/6364a0299330a1ac060f0794f4638f82c0dc5cc2
Cr-Commit-Position: refs/heads/master@{#344637}