Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h

Issue 1296453004: Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cherry-pick GL_APIENTRY addition back in Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h
diff --git a/third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h b/third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h
index 48c74c6eb67b1807b2279100589ac5528ad2a3b5..860260ed7d7bea6763318a787d069ba54dc212da 100644
--- a/third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h
+++ b/third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h
@@ -10,7 +10,6 @@
#include "mojo/public/c/environment/async_waiter.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "mojo/public/cpp/bindings/callback.h"
-#include "mojo/public/cpp/bindings/error_handler.h"
#include "mojo/public/cpp/bindings/interface_ptr.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/cpp/bindings/lib/filter_chain.h"
@@ -104,21 +103,11 @@ class StrongBinding {
return binding_.WaitForIncomingMethodCall();
}
+ // Note: The error handler must not delete the interface implementation.
void set_connection_error_handler(const Closure& error_handler) {
connection_error_handler_ = error_handler;
}
- // NOTE: Deprecated. Please use the method above.
- // TODO(yzshen): Remove this method once all callsites are converted.
- void set_error_handler(ErrorHandler* error_handler) {
- if (error_handler) {
- set_connection_error_handler(
- [error_handler]() { error_handler->OnConnectionError(); });
- } else {
- set_connection_error_handler(Closure());
- }
- }
-
Interface* impl() { return binding_.impl(); }
// Exposed for testing, should not generally be used.
internal::Router* internal_router() { return binding_.internal_router(); }

Powered by Google App Engine
This is Rietveld 408576698