LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html - Issue 129643002: Fix link highlights on links that contain images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html

Issue 129643002: Fix link highlights on links that contain images. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed.html ('k') | LayoutTests/compositing/gestures/resources/link-highlight-helper.js » ('j') | Source/web/LinkHighlight.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html

diff --git a/LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html b/LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html

index ab1fea866cde4b3ff5f1ac846cccc9067003b715..2ffd3c92fcfe402379e237a21f728393a6cc0457 100644

--- a/LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html

+++ b/LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html

@@ -1,31 +1,23 @@

<!DOCTYPE html>

<html>

<head>

-<script src="../../resources/js-test.js"></script>

+<script src="resources/link-highlight-helper.js"></script>

+<link rel="stylesheet" type="text/css" href="resources/link-highlight-style.css">

</head>

- <div style="-webkit-transform: translatez(0) translatey(100px) translatex(300px)">

- <div id="targetLink" style="width: 320px; height: 240px; cursor: pointer; -webkit-tap-highlight-color: rgb(0, 255, 0)">

+ <div id="targetLink" style="margin: 0px; padding: 0px; position: relative; top: 100px; left: 300px; width: 320px;">

+ <!--Note we set the height to 1 less than the actual highlight. Determining the size here programatically

+ is challenging as the highlight code uses a (I believe) buggy line box calculation and it's not exposed

+ via javascript. To see this, highlight the <a> element in dev tools and not that it's at the bottom of

+ the image yet it's .top() method is 28px -->

+ <a href="#"><img width="320" height="239" src="resources/dice.png"></a>

</div>

- </div>

function runTest() {

- var clientRect = document.getElementById('targetLink').getBoundingClientRect();

- x = (clientRect.left + clientRect.right) / 2;

- y = (clientRect.top + clientRect.bottom) / 2;

- if (window.testRunner) {

+ var targetLink = document.getElementById('targetLink');

+ createSquareCompositedHighlight(targetLink);

+ if (window.testRunner)

testRunner.dumpAsTextWithPixelResults();

- testRunner.waitUntilDone();

- }

- if (window.eventSender) {

- eventSender.gestureShowPress(x, y);

- window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);

- } else {

- debug("This test requires DumpRenderTree.");

- debug("This test is successful if the image below is covered in a green rectangle.");

- }

}

</script>