LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed.html - Issue 129643002: Fix link highlights on links that contain images.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed.html

Issue 129643002: Fix link highlights on links that contain images. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/compositing/gestures/gesture-tapHighlight-img-expected.html ('k') | LayoutTests/compositing/gestures/gesture-tapHighlight-img-transformed-expected.html » ('j') | Source/web/LinkHighlight.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>

5 </head>	4 </head>

6 <body onload="runTest();" style="overflow: hidden">	5 <body onload="runTest();" style="overflow: hidden">

7 <div style="-webkit-transform: translatez(0) translatey(100px) translatex(300p x);">	6 <div style="-webkit-transform: translatez(0) translatey(100px) translatex(300p x);">

8 <a href="" style="-webkit-tap-highlight-color: rgb(0, 255, 0)">	7 <a href="" style="-webkit-tap-highlight-color: rgb(0, 255, 0)">

9 <img width="320" height="240" id="targetLink" src="resources/dice.png">	8 <img width="320" height="240" id="targetLink" src="resources/dice.png">

10 </a>	9 </a>

11 </div>	10 </div>

12 <script>	11 <script>

13 function runTest() {	12 function runTest() {

14 var clientRect = document.getElementById('targetLink').getBoundingClientRect ();	13 var clientRect = document.getElementById('targetLink').getBoundingClientRect ();

(...skipping 10 matching lines...) Expand all Loading...
25 window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);	24 window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);

26 } else {	25 } else {

27 debug("This test requires DumpRenderTree.");	26 debug("This test requires DumpRenderTree.");

28 debug("This test is successful if the image below is covered in a green rectangle.");	27 debug("This test is successful if the image below is covered in a green rectangle.");

29 }	28 }

30 }	29 }

31 </script>	30 </script>

32 </script>	31 </script>

33 </body>	32 </body>

34 </html>	33 </html>

OLD	NEW