LayoutTests/compositing/gestures/gesture-tapHighlight-img-and-text.html - Issue 129643002: Fix link highlights on links that contain images.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/compositing/gestures/gesture-tapHighlight-img-and-text.html

Issue 129643002: Fix link highlights on links that contain images. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/compositing/gestures/gesture-tapHighlight-img.html ('k') | LayoutTests/compositing/gestures/gesture-tapHighlight-img-and-text-2.html » ('j') | Source/web/LinkHighlight.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <title>This test ensures all elements are highlighted in a multielement <a> when the text is clicked</title>

5 </head>	5 </head>

6 <body onload="runTest();">	6 <body onload="runTest();">

7 <div style="-webkit-transform: translateZ(0); padding: 20px;">	7 <div style="-webkit-transform: translateZ(0); padding: 20px;">

8 <a href="" id="targetLink" style="-webkit-tap-highlight-color: rgb(0, 255, 0)">< img width="320" height="240" src="resources/dice.png"></a>	8 <a href="" id="targetLink" style="-webkit-tap-highlight-color: rgb(0, 255, 0)">

	9 <font id="beforeTarget">Before Text</font>

	10 <img id="imgTarget" width="320" height="240" src="resources/dice.png">

	11 <font id="afterTarget">After Text</font>

	12 </a>

9 </div>	13 </div>

10 <script>	14 <script>

11 function runTest() {	15 function runTest() {

12 var clientRect = document.getElementById('targetLink').getBoundingClientRect ();	16 var clientRect = document.getElementById('beforeTarget').getBoundingClientRe ct();

13 x = (clientRect.left + clientRect.right) / 2;	17 x = (clientRect.left + clientRect.right) / 2;

14 y = (clientRect.top + clientRect.bottom) / 2;	18 y = (clientRect.top + clientRect.bottom) / 2;

15 if (window.testRunner) {	19 if (window.testRunner) {

16 testRunner.dumpAsTextWithPixelResults();	20 testRunner.dumpAsTextWithPixelResults();

17 testRunner.waitUntilDone();	21 testRunner.waitUntilDone();

18 }	22 }

19	23

20 if (window.eventSender) {	24 if (window.eventSender) {

21 eventSender.gestureShowPress(x, y);	25 eventSender.gestureShowPress(x, y);

22 window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);	26 window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);

23 } else {	27 } else {

24 debug("This test requires DumpRenderTree.");	28 debug("This test requires DumpRenderTree.");

25 debug("This test is successful if the image below is covered in a green rectangle with rounded corners.");	29 debug("This test is successful if the image and text below is covered in a green rectangle.");

26 }	30 }

27 }	31 }

28 </script>	32 </script>

29 </script>	33 </script>

30 </body>	34 </body>

31 </html>	35 </html>

OLD	NEW