Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1296383006: Bug fix: we're using SkPMColor methods on SkColor (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
mtklein, Noel Gordon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Bug fix: we're using SkPMColor methods on SkColor. Annoyingly our test bot that forces SkPMFloat_none is a Linux bot using BGRA SkPMColors, so we'd never notice the bug there. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3679c1bbe7f1e611d7c06b1134e16049799a3ac6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/opts/SkPMFloat_none.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
mtklein_C
5 years, 4 months ago (2015-08-19 18:03:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296383006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296383006/1
5 years, 4 months ago (2015-08-19 18:03:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 18:10:15 UTC) #6
Noel Gordon
LGTM.
5 years, 4 months ago (2015-08-19 23:59:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296383006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296383006/1
5 years, 4 months ago (2015-08-20 00:05:36 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-20 00:05:37 UTC) #10
mtklein
lgtm
5 years, 4 months ago (2015-08-20 00:05:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296383006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296383006/1
5 years, 4 months ago (2015-08-20 00:06:04 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3679c1bbe7f1e611d7c06b1134e16049799a3ac6
5 years, 4 months ago (2015-08-20 00:06:41 UTC) #15
mtklein
5 years, 4 months ago (2015-08-20 00:20:56 UTC) #16
Message was sent while issue was closed.
On 2015/08/20 00:06:41, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/3679c1bbe7f1e611d7c06b1134e16049799a3ac6

*SkPMColor methods

Powered by Google App Engine
This is Rietveld 408576698