Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1296383005: Remove FIXME re: negative maxHeight. (Closed)

Created:
5 years, 4 months ago by wkorman
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove FIXME re: negative maxHeight. Confirmed that it is possible to construct a page that will produce a negative maxHeight, as seen in: fast/block/line-layout/negative-max-height.html which produces maxHeight of -5. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/layout/line/RootInlineBox.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wkorman
I'd like to improve the documentation as well but doing so best done with some ...
5 years, 4 months ago (2015-08-18 02:05:41 UTC) #2
wkorman
Also for the record, the FIXME was added in: https://chromium.googlesource.com/chromium/blink/+/3a9092670530f51a4c79730b66d68ef441a3fee4 which was for https://bugs.webkit.org/show_bug.cgi?id=67202
5 years, 4 months ago (2015-08-18 02:07:17 UTC) #3
eae
LGTM
5 years, 4 months ago (2015-08-18 16:10:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296383005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296383005/1
5 years, 4 months ago (2015-08-18 16:10:09 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:40:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200734

Powered by Google App Engine
This is Rietveld 408576698