Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296383004: Fix fix fix fix of breakage on mac. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : missing decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M core/src/fxge/ge/fx_ge_text.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
try try again.
5 years, 4 months ago (2015-08-18 00:19:31 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1296383004/diff/1/core/src/fxge/ge/fx_ge_text.cpp File core/src/fxge/ge/fx_ge_text.cpp (right): https://codereview.chromium.org/1296383004/diff/1/core/src/fxge/ge/fx_ge_text.cpp#newcode1354 core/src/fxge/ge/fx_ge_text.cpp:1354: pSizeCache = new CFX_SizeGlyphCache; This needs to be ...
5 years, 4 months ago (2015-08-18 00:23:19 UTC) #3
Tom Sepez
On 2015/08/18 00:23:19, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/1296383004/diff/1/core/src/fxge/ge/fx_ge_text.cpp > File core/src/fxge/ge/fx_ge_text.cpp (right): ...
5 years, 4 months ago (2015-08-18 00:26:50 UTC) #4
Tom Sepez
5 years, 4 months ago (2015-08-18 00:27:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1d9dbd53b205b2b4d9e75a7eeb95e80837917ea3 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698