Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1296373003: Remove unused assets, update old assets (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
oshima, fukino
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused assets, update old assets - about_sys changes copied from about:memory-internals - .topbutton-bar .gear-button was not used anywhere (not to be confused with file manager's #gear-button) - some files moved to shared location or moved from shared location to specific location TBR=fukino@chromium.org BUG=522168, 505953 Committed: https://crrev.com/f149d9533f0e62e0f01d663dcc87d59e80d97b0a Cr-Commit-Position: refs/heads/master@{#344247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M chrome/browser/resources/about_sys/about_sys.css View 4 chunks +17 lines, -11 lines 0 comments Download
D chrome/browser/resources/help/check_circle.svg View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/help/help_content.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/import_data_overlay.css View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 1 chunk +1 line, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/drive_welcome.css View 1 chunk +1 line, -1 line 0 comments Download
A + ui/file_manager/file_manager/foreground/images/files/ui/clouds.png View Binary file 0 comments Download
M ui/webui/resources/css/apps/topbutton_bar.css View 1 chunk +0 lines, -6 lines 0 comments Download
D ui/webui/resources/images/2x/apps/topbar_button_settings.png View Binary file 0 comments Download
D ui/webui/resources/images/2x/gear.png View Binary file 0 comments Download
D ui/webui/resources/images/apps/topbar_button_settings.png View Binary file 0 comments Download
A + ui/webui/resources/images/check_circle.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/webui/resources/images/clouds.png View Binary file 0 comments Download
D ui/webui/resources/images/gear.png View Binary file 0 comments Download
D ui/webui/resources/images/success.png View Binary file 0 comments Download
M ui/webui/resources/webui_resources.grd View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Evan Stade
5 years, 4 months ago (2015-08-18 23:02:54 UTC) #2
oshima
lgtm
5 years, 4 months ago (2015-08-19 00:43:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296373003/1
5 years, 4 months ago (2015-08-19 06:20:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/89893)
5 years, 4 months ago (2015-08-19 06:29:18 UTC) #7
Evan Stade
TBR fukino@ for ui/file_manager/ (it's just a file move)
5 years, 4 months ago (2015-08-19 16:18:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296373003/1
5 years, 4 months ago (2015-08-19 16:18:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 16:23:13 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:23:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f149d9533f0e62e0f01d663dcc87d59e80d97b0a
Cr-Commit-Position: refs/heads/master@{#344247}

Powered by Google App Engine
This is Rietveld 408576698