Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 1296363005: Sync GN unit tests with GYP, add checking script. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync GN unit tests with GYP, add checking script. Some of these JavaScript gtest tests were missing from the GN build because they needed to go into a special target. The included script will find and print out lists of test differences. Reland of https://codereview.chromium.org/1289423004/ with data added to the js2gtest template so it works in swarming. TBR=jam BUG=521944

Patch Set 1 : Original patch #

Patch Set 2 : add gtest files to data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -3 lines) Patch
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/base/js2gtest.gni View 1 3 chunks +9 lines, -2 lines 0 comments Download
A tools/gn/bin/compare_test_lists.py View 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brettw
5 years, 4 months ago (2015-08-18 20:12:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296363005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296363005/20001
5 years, 4 months ago (2015-08-18 20:13:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94841)
5 years, 4 months ago (2015-08-18 21:35:45 UTC) #6
brettw
5 years, 4 months ago (2015-08-18 21:41:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) to pending queue manually as
c1b38c56146838ff3e73757595672714b389018f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698