Source/core/layout/LayoutMedia.cpp - Issue 1296333002: Removed clientHeight() from MediaControlsPainter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutMedia.cpp

Issue 1296333002: Removed clientHeight() from MediaControlsPainter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: removed TODO. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutMedia.cpp

diff --git a/Source/core/layout/LayoutMedia.cpp b/Source/core/layout/LayoutMedia.cpp

index 374c4b1889cb25e1e8043d9c099085f857c5906d..b63e126b5f47cf8709f0c494f6e2205b00260835 100644

--- a/Source/core/layout/LayoutMedia.cpp

+++ b/Source/core/layout/LayoutMedia.cpp

@@ -90,8 +90,8 @@ void LayoutMedia::layout()

clearNeedsLayout();

// Notify our MediaControls that a layout has happened.

- if (mediaElement() && mediaElement()->mediaControls() && newSize.width() != oldSize.width())

- mediaElement()->mediaControls()->notifyPanelWidthChanged(newSize.width());

+ if (mediaElement() && newSize != oldSize)

+ mediaElement()->notifySizeChanged(newSize);

}

bool LayoutMedia::isChildAllowed(LayoutObject* child, const ComputedStyle&) const

« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/paint/MediaControlsPainter.cpp » ('j') | Source/core/paint/MediaControlsPainter.cpp » ('J')