Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 1296333002: Removed clientHeight() from MediaControlsPainter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: removed TODO. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/paint/MediaControlsPainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 6cdc6faf30d5ba317298a5e871fc2c74c89f502e..ff5045eec3480e9f76d2120710eb4aab6cdb7dd2 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -265,6 +265,14 @@ public:
virtual bool isHTMLAudioElement() const { return false; }
virtual bool isHTMLVideoElement() const { return false; }
+ // Notify us that we have changed layout size. This is useful so that we
+ // can paint based on our last known size, without having to trigger a
+ // layout mid-paint.
+ void notifySizeChanged(const LayoutSize& newSize);
+
+ // Get the last known layout size that we were given by notifySizeChanged.
+ const LayoutSize& cachedLayoutSize() const { return m_cachedSize; }
+
protected:
HTMLMediaElement(const QualifiedName&, Document&);
~HTMLMediaElement() override;
@@ -620,6 +628,8 @@ private:
friend class MediaController;
PersistentWillBeMember<MediaController> m_mediaController;
+ LayoutSize m_cachedSize;
+
friend class Internals;
friend class TrackDisplayUpdateScope;
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/paint/MediaControlsPainter.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698