Removed clientHeight() from MediaControlsPainter.

Source/core/paint/MediaControlsPainter.cpp

 /*
  * Copyright (C) 2009 Apple Inc.
  * Copyright (C) 2009 Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 155 matching lines @@
     if (!hasSource(mediaElement) || !mediaElement->togglePlayStateWillPlay())
         return false;
 
     static Image* mediaOverlayPlay = platformResource("mediaplayerOverlayPlay",
         "mediaplayerOverlayPlayNew");
 
     IntRect buttonRect(rect);
     if (RuntimeEnabledFeatures::newMediaPlaybackUiEnabled()) {
         // Overlay play button covers the entire player, so center and draw a
         // smaller button.  Center in the entire element.
-        int mediaHeight = mediaElement->clientHeight();
+        const LayoutBox* box = mediaElement->layoutObject()->enclosingBox();

[liberato (no reviews please), 2015/08/18 16:26:41]

That was much easier than i expected.  gets rid of zoom, too. 
enclosingBox::frameRect() is used for the paint rects directly.

I could replace the existing current use of clientHeight()-via-callback (see
first CL) in MediaControls with this, couldn't I?

[fs, 2015/08/18 16:41:19]

You mean the stuff in MediaControls::notifyPanelWidthChanged? Seems likely if
so.

+        if (!box)
+            return false;
+        int mediaHeight = ceil(box->size().height().toDouble());

[fs, 2015/08/18 16:41:18]

You could consider using pixelSnappedHeight() here instead. (And if you want the
client* metric, then that is available on LayoutBox as well.)

         buttonRect.setX(rect.center().x() - mediaOverlayPlayButtonWidthNew / 2);
         buttonRect.setY(rect.center().y() - mediaOverlayPlayButtonHeightNew / 2
             + (mediaHeight - rect.height()) / 2);
         buttonRect.setWidth(mediaOverlayPlayButtonWidthNew);
         buttonRect.setHeight(mediaOverlayPlayButtonHeightNew);
     }
 
     return paintMediaButton(paintInfo.context, buttonRect, mediaOverlayPlay);
 }
 
@@ skipping 380 matching lines @@
     }
 
     float zoomLevel = style.effectiveZoom();
     if (thumbImage) {
         style.setWidth(Length(static_cast<int>(width * zoomLevel), Fixed));
         style.setHeight(Length(static_cast<int>(height * zoomLevel), Fixed));
     }
 }
 
 } // namespace blink