Issue 129633005: Introduce a monotonic_clock module for Mojo.js.

Issue 129633005: Introduce a monotonic_clock module for Mojo.js. (Closed)

Created:
6 years, 11 months ago by Aaron Boodman

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Introduce a monotonic_clock module for Mojo.js. Am having trouble coming up with a satisfactory way to test. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244062

Patch Set 3 : blech #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -39 lines)			Patch
M	gin/test/file_runner.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	gin/test/file_runner.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
A +	mojo/apps/js/bindings/monotonic_clock.h	View		1 chunk	+4 lines, -7 lines	0 comments	Download
A +	mojo/apps/js/bindings/monotonic_clock.cc	View	1	1 chunk	+13 lines, -18 lines	0 comments	Download
A	mojo/apps/js/bindings/monotonic_clock_unittests.js	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	mojo/apps/js/main.js	View		5 chunks	+8 lines, -6 lines	0 comments	Download
M	mojo/apps/js/mojo_runner_delegate.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	mojo/apps/js/test/run_js_tests.cc	View	1	4 chunks	+18 lines, -5 lines	0 comments	Download
M	mojo/mojo_apps.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM If you want a test, you can just test that you can call the ...

6 years, 11 months ago (2014-01-09 00:20:46 UTC) #2

Aaron Boodman

added test https://codereview.chromium.org/129633005/diff/1/mojo/apps/js/bindings/monotonic_clock.cc File mojo/apps/js/bindings/monotonic_clock.cc (right): https://codereview.chromium.org/129633005/diff/1/mojo/apps/js/bindings/monotonic_clock.cc#newcode24 mojo/apps/js/bindings/monotonic_clock.cc:24: base::Time::kMillisecondsPerSecond); On 2014/01/09 00:20:46, abarth wrote: > ...

6 years, 11 months ago (2014-01-09 22:34:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/129633005/130001

6 years, 11 months ago (2014-01-10 00:36:53 UTC) #5

Message was sent while issue was closed.

Change committed as 244062

Expand Messages | Collapse Messages