Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129633002: Also append GPU command-line flags to the browser in single-process mode (Closed)

Created:
6 years, 11 months ago by piman
Modified:
6 years, 11 months ago
Reviewers:
danakj, jamesr, danakj1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Also append GPU command-line flags to the browser in single-process mode BUG=314909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244059

Patch Set 1 #

Patch Set 2 : style #

Total comments: 2

Patch Set 3 : Also do GPU process #

Patch Set 4 : Fix single-process cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -33 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 1 chunk +1 line, -12 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 chunks +33 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
piman
Temporary hack, waiting for a better patch... WDYT?
6 years, 11 months ago (2014-01-08 22:16:41 UTC) #1
jamesr
https://codereview.chromium.org/129633002/diff/50001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/129633002/diff/50001/content/browser/renderer_host/render_process_host_impl.cc#newcode904 content/browser/renderer_host/render_process_host_impl.cc:904: // Appending disable-gpu-feature switches due to software rendering list. ...
6 years, 11 months ago (2014-01-08 22:20:39 UTC) #2
danakj
I'm a little bit more than OK with this. :)
6 years, 11 months ago (2014-01-08 22:22:41 UTC) #3
piman
Is this what you're thinking of?
6 years, 11 months ago (2014-01-08 22:38:07 UTC) #4
jamesr
yeah, seems at least a bit more consistent. lgtm
6 years, 11 months ago (2014-01-08 22:41:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/129633002/90001
6 years, 11 months ago (2014-01-08 22:49:41 UTC) #6
piman
PTAL for the extra fix to single-process teardown.
6 years, 11 months ago (2014-01-09 01:34:35 UTC) #7
jamesr
lgtm
6 years, 11 months ago (2014-01-09 22:45:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/129633002/370001
6 years, 11 months ago (2014-01-09 22:57:57 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=111372
6 years, 11 months ago (2014-01-10 00:54:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/129633002/370001
6 years, 11 months ago (2014-01-10 01:09:56 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 02:56:05 UTC) #12
Message was sent while issue was closed. 
Change committed as 244059

Powered by Google App Engine
This is Rietveld 408576698