Refactor skia_warnings_as_errors

gyp/jsoncpp.gyp

Index: gyp/jsoncpp.gyp
===================================================================
--- gyp/jsoncpp.gyp	(revision 8147)
+++ gyp/jsoncpp.gyp	(working copy)
@@ -47,29 +47,38 @@
         ],
       },
       'conditions': [
-        [ 'skia_os == "mac"', {
-          'xcode_settings': {
-            'OTHER_CPLUSPLUSFLAGS!': [
-              '-Werror',
-            ]
-          },
-        }],
-        [ 'skia_os == "win"', {
-          'msvs_settings': {
-            'VCCLCompilerTool': {
-              'WarnAsError': 'false',
-            },
-          },
-        }],
         [ 'skia_os == "android"', {
           'cflags!': [
             '-Wall',
-            '-Werror',
           ],
         }],
-        ['skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl"]', {
-          'cflags!': [
-            '-Werror',
+        # Turn off warnings as errors.
+        [ 'skia_warnings_as_errors', {

[djsollen, 2013/03/20 17:43:29]

is there a better way than listing these out each time?

[borenet, 2013/03/20 19:19:34]

I combined android into the linux set, but since mac and win require different
exclusions, AFAIK there's not really another good way.

+          'conditions': [
+            [ 'skia_os == "mac"', {
+              'xcode_settings': {
+                'OTHER_CPLUSPLUSFLAGS!': [
+                  '-Werror',
+                ]
+              },
+            }],
+            [ 'skia_os == "win"', {
+              'msvs_settings': {
+                'VCCLCompilerTool': {
+                  'WarnAsError': 'false',
+                },
+              },
+            }],
+            [ 'skia_os == "android"', {
+              'cflags!': [
+                '-Werror',
+              ],
+            }],
+            ['skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl"]', {
+              'cflags!': [
+                '-Werror',
+              ],
+            }],
           ],
         }],
       ],