Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: gyp/utils.gyp

Issue 12963002: Refactor skia_warnings_as_errors (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Fix merge conflicts and trybot failures Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« gyp/jsoncpp.gyp ('K') | « gyp/libjpeg.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'targets': [ 2 'targets': [
3 { 3 {
4 'target_name': 'utils', 4 'target_name': 'utils',
5 'product_name': 'skia_utils', 5 'product_name': 'skia_utils',
6 'type': 'static_library', 6 'type': 'static_library',
7 'standalone_static_library': 1, 7 'standalone_static_library': 1,
8 'dependencies': [ 8 'dependencies': [
9 'cityhash', 9 'cityhash',
10 ], 10 ],
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 ], 231 ],
232 'sources': [ 232 'sources': [
233 '../third_party/externals/cityhash/src/city.cc', 233 '../third_party/externals/cityhash/src/city.cc',
234 ], 234 ],
235 'direct_dependent_settings': { 235 'direct_dependent_settings': {
236 'include_dirs': [ 236 'include_dirs': [
237 '../third_party/externals/cityhash/src', 237 '../third_party/externals/cityhash/src',
238 ], 238 ],
239 }, 239 },
240 'conditions': [ 240 'conditions': [
241 [ 'skia_os == "mac"', {
242 'xcode_settings': {
243 'OTHER_CPLUSPLUSFLAGS!': [
244 '-Werror',
245 ]
246 },
247 }],
248 [ 'skia_os == "win"', {
249 'msvs_settings': {
250 'VCCLCompilerTool': {
251 'WarnAsError': 'false',
252 },
253 },
254 }],
255 [ 'skia_os == "android"', { 241 [ 'skia_os == "android"', {
256 'cflags!': [ 242 'cflags!': [
257 '-Wall', 243 '-Wall',
258 '-Werror',
259 ], 244 ],
260 }], 245 }],
261 ['skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl"]', { 246 # Turn off warnings as errors.
262 'cflags!': [ 247 [ 'skia_warnings_as_errors', {
263 '-Werror', 248 'conditions': [
249 [ 'skia_os == "mac" or skia_os == "ios"', {
250 'xcode_settings': {
251 'OTHER_CPLUSPLUSFLAGS!': [
252 '-Werror',
253 ]
254 },
255 }],
256 [ 'skia_os == "win"', {
257 'msvs_settings': {
258 'VCCLCompilerTool': {
259 'WarnAsError': 'false',
260 },
261 },
262 }],
263 [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl", "an droid"]', {
264 'cflags!': [
265 '-Werror',
266 ],
267 }],
264 ], 268 ],
265 }], 269 }],
266 ], 270 ],
267 }, 271 },
268 ], 272 ],
269 } 273 }
270 274
271 # Local Variables: 275 # Local Variables:
272 # tab-width:2 276 # tab-width:2
273 # indent-tabs-mode:nil 277 # indent-tabs-mode:nil
274 # End: 278 # End:
275 # vim: set expandtab tabstop=2 shiftwidth=2: 279 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« gyp/jsoncpp.gyp ('K') | « gyp/libjpeg.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698