Refactor skia_warnings_as_errors

gyp/common_variables.gypi

 # Copyright 2012 The Android Open Source Project
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   # Get ready for the ugly...
   #
   # - We have to nest our variables dictionaries multiple levels deep, so that
   #   this and other gyp files can rely on previously-set variable values in
@@ skipping 71 matching lines @@
       'skia_mesa%': 0,
       'skia_nv_path_rendering%': 0,
       'skia_stroke_path_rendering%': 0,
       'skia_android_path_rendering%': 0,
       'skia_texture_cache_mb_limit%': 0,
       'skia_angle%': 0,
       'skia_directwrite%': 0,
       'skia_gpu%': 1,
       'skia_osx_sdkroot%': '',
       'skia_profile_enabled%': 0,
-      # Note: This is currently only turned on for linux and android.
-      # TODO: Turn on for Win and Mac as well.
-      'skia_warnings_as_errors%': 0,
       'skia_win_debuggers_path%': '',
     },
 
+    'conditions': [
+      [ 'skia_os == "win" and skia_arch_width == 32 and not skia_angle', {
+        'skia_warnings_as_errors%': 1,
+      }],
+      [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris"]', {

[djsollen, 2013/03/20 17:43:29]

why not put android and ios in this list?

[borenet, 2013/03/20 19:19:34]

Combined into one condition.  It was necessary for the "else" condition, which
would have been very complicated otherwise.

+        'skia_warnings_as_errors%': 1,
+      }],
+      [ 'skia_os == "android"', {
+        'skia_warnings_as_errors%': 1,
+      }],
+      [ 'skia_os == "mac" and skia_arch_width == 32', {
+        'skia_warnings_as_errors%': 1,
+      }],
+      [ 'skia_os == "ios"', {
+        'skia_warnings_as_errors%': 1,
+      }],
+    ],
+
     # Re-define all variables defined within the level-2 'variables' dict,
     # so that siblings of the level-1 'variables' dict can see them.
     'armv7%': '<(armv7)',
     'arm_neon%': '<(arm_neon)',
     'skia_os%': '<(skia_os)',
     'os_posix%': '<(os_posix)',
     'skia_scalar%': '<(skia_scalar)',
     'skia_mesa%': '<(skia_mesa)',
     'skia_nv_path_rendering%': '<(skia_nv_path_rendering)',
     'skia_stroke_path_rendering%': '<(skia_stroke_path_rendering)',
@@ skipping 15 matching lines @@
     #
     'skia_src_path%': '../src',
     'skia_include_path%': '../include',
   },
 }
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: