Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1296283003: Replace Chromium .ico files with Material Design versions. (Closed)

Created:
5 years, 4 months ago by Matt Giuca
Modified:
5 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@chromium-ico-remove-24
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace Chromium .ico files with Material Design versions. BUG=517654 Committed: https://crrev.com/2fc0baecacffffb7aa2d5a6c891667acda6d9c8c Cr-Commit-Position: refs/heads/master@{#344091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/app/theme/chromium/win/chromium.ico View Binary file 0 comments Download
M chrome/app/theme/chromium/win/webstore.ico View Binary file 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (2 generated)
Matt Giuca
5 years, 4 months ago (2015-08-18 07:38:28 UTC) #2
oshima
lgtm the size of webstore.ico is quite different, but I think that's expected based on ...
5 years, 4 months ago (2015-08-18 07:41:53 UTC) #3
Matt Giuca
+estade
5 years, 4 months ago (2015-08-18 07:44:54 UTC) #4
Matt Giuca
On 2015/08/18 07:41:53, oshima wrote: > lgtm > > the size of webstore.ico is quite ...
5 years, 4 months ago (2015-08-18 07:53:39 UTC) #5
Evan Stade
On 2015/08/18 07:53:39, Matt Giuca wrote: > On 2015/08/18 07:41:53, oshima wrote: > > lgtm ...
5 years, 4 months ago (2015-08-18 14:43:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296283003/1
5 years, 4 months ago (2015-08-18 23:58:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 00:09:46 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 00:10:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fc0baecacffffb7aa2d5a6c891667acda6d9c8c
Cr-Commit-Position: refs/heads/master@{#344091}

Powered by Google App Engine
This is Rietveld 408576698