Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1296283002: Create list file for GN target //remoting/webapp:unit_tests (Closed)

Created:
5 years, 4 months ago by kelvinp
Modified:
5 years, 4 months ago
Reviewers:
Jamie, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create list file for GN target //remoting/webapp:unit_tests This is needed to avoid problems on platforms that limit the size of a command line. This CL also fixes an ordering issue that causes a GN compiler error. Committed: https://crrev.com/468590800de45688381817e4803ac4a0bfc9bb97 Cr-Commit-Position: refs/heads/master@{#343763}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
M remoting/webapp/BUILD.gn View 1 chunk +18 lines, -7 lines 0 comments Download
M remoting/webapp/build-html.py View 2 chunks +19 lines, -2 lines 0 comments Download
M remoting/webapp/files.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
kelvinp
PTAL
5 years, 4 months ago (2015-08-17 18:33:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296283002/40001
5 years, 4 months ago (2015-08-17 18:48:08 UTC) #6
dcaiafa
lgtm
5 years, 4 months ago (2015-08-17 21:19:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296283002/40001
5 years, 4 months ago (2015-08-17 21:30:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296283002/40001
5 years, 4 months ago (2015-08-17 22:21:09 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 4 months ago (2015-08-17 22:44:02 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 22:44:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/468590800de45688381817e4803ac4a0bfc9bb97
Cr-Commit-Position: refs/heads/master@{#343763}

Powered by Google App Engine
This is Rietveld 408576698