Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1296253003: Depend on ETC1 via DEPS instead of a direct third_party checkin. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Depend on ETC1 via DEPS instead of a direct third_party checkin. Yes, this does mean we'll check out ~40M of code for 2 files... I think these trybots are moot... they gclient sync before patching. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ca01d179347b5e848ded97c8228b79ffc6b5e7bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -964 lines) Patch
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/etc1.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/etc1/LICENSE View 1 chunk +0 lines, -161 lines 0 comments Download
D third_party/etc1/README.google View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/etc1/etc1.h View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/etc1/etc1.cpp View 1 chunk +0 lines, -678 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296253003/1
5 years, 4 months ago (2015-08-17 16:28:30 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-17 16:33:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-17 16:34:45 UTC) #6
robertphillips
lgtm
5 years, 4 months ago (2015-08-17 17:09:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296253003/1
5 years, 4 months ago (2015-08-17 17:19:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ca01d179347b5e848ded97c8228b79ffc6b5e7bf
5 years, 4 months ago (2015-08-17 17:20:19 UTC) #10
djsollen
this breaks the android framework builds as we no longer look in the proper spot ...
5 years, 4 months ago (2015-08-17 17:52:35 UTC) #12
mtklein
5 years, 4 months ago (2015-08-17 18:14:42 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1290913008/ by mtklein@google.com.

The reason for reverting is: This will make the google3 roll awkward. 
Reverting..

Powered by Google App Engine
This is Rietveld 408576698