Oilpan: Move MainThreadTaskRunner into Oilpan heap.

Source/core/dom/MainThreadTaskRunner.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 11 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef MainThreadTaskRunner_h
 #define MainThreadTaskRunner_h
 
 #include "core/CoreExport.h"
 #include "platform/Timer.h"
-
+#include "platform/heap/Handle.h"
 #include "wtf/FastAllocBase.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/Vector.h"
 #include "wtf/WeakPtr.h"
 
 namespace blink {
 
 class ExecutionContext;
 class ExecutionContextTask;
 
-class CORE_EXPORT MainThreadTaskRunner {
+class CORE_EXPORT MainThreadTaskRunner final : public NoBaseWillBeGarbageCollectedFinalized<MainThreadTaskRunner> {
     WTF_MAKE_NONCOPYABLE(MainThreadTaskRunner);
-    WTF_MAKE_FAST_ALLOCATED(MainThreadTaskRunner);
+    WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(MainThreadTaskRunner);
 
 public:
-    static PassOwnPtr<MainThreadTaskRunner> create(ExecutionContext*);
+    static PassOwnPtrWillBeRawPtr<MainThreadTaskRunner> create(ExecutionContext*);
 
     ~MainThreadTaskRunner();
 
+    DECLARE_TRACE();
+
     void postTask(const WebTraceLocation&, PassOwnPtr<ExecutionContextTask>); // Executes the task on context's thread asynchronously.
     void postInspectorTask(const WebTraceLocation&, PassOwnPtr<ExecutionContextTask>);
     void perform(PassOwnPtr<ExecutionContextTask>, bool);
 
     void suspend();
     void resume();
 
 private:
     explicit MainThreadTaskRunner(ExecutionContext*);
 
     void pendingTasksTimerFired(Timer<MainThreadTaskRunner>*);
 
-    ExecutionContext* m_context;
+    RawPtrWillBeMember<ExecutionContext> m_context;
     WeakPtrFactory<MainThreadTaskRunner> m_weakFactory;

[sof, 2015/08/18 07:15:31]

Doesn't this need to be eagerly finalized?

[haraken, 2015/08/18 08:08:54]

I don't see any issue in not eagerly finalizing the MainThreadTaskRunner, but I
agree that it's nasty to let the MainThreadTask keep WeakPtr<MainThreadRunner>.
(i.e., it's nasty to have a WeakPtr to an on-heap object -- it should be a
WeakPersistent or WeakMember.)

Would it be better to add #if !ENABLE(OILPAN) to m_weakFactory and use a
WeakPersistent from MainThreadTask to the MainThreadTaskRunner? (Maybe does it
need to be CrossThreadWeakPersistent?)

[sof, 2015/08/18 13:54:45]

Could you explain your reasoning behind that assessment?

It is a problem to have this task runner be able to access m_context if
it(Document) has already been finalized. Which it might have been if this object
isn't eagerly finalized.

     Timer<MainThreadTaskRunner> m_pendingTasksTimer;
     Vector<OwnPtr<ExecutionContextTask>> m_pendingTasks;
     bool m_suspended;
 };
 
-inline PassOwnPtr<MainThreadTaskRunner> MainThreadTaskRunner::create(ExecutionContext* context)
+inline PassOwnPtrWillBeRawPtr<MainThreadTaskRunner> MainThreadTaskRunner::create(ExecutionContext* context)
 {
-    return adoptPtr(new MainThreadTaskRunner(context));
+    return adoptPtrWillBeNoop(new MainThreadTaskRunner(context));
 }
 
 } // namespace
 
 #endif