Issue 1296243003: Fix errorprone NarrowingCompoundAssignment error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1296243003: Fix errorprone NarrowingCompoundAssignment error. (Closed)

Created:
5 years, 4 months ago by mikecase (-- gone --)

Modified:
5 years, 4 months ago

Reviewers:
jamesr, etiennej, ppi

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix errorprone NarrowingCompoundAssignment error. We want to start using the errorprone compiler in Chromium. Ran into the following error in third_party/mojo/src... http://errorprone.info/bugpattern/NarrowingCompoundAssignment BUG= R=jamesr@chromium.org, ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/91530d5e330134c9cbe90aff9ddf990b50a1bb75

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

lgtm The Paris folks normally work on the java bindings stuff. ppi/etiennej, since qsr is ...

5 years, 4 months ago (2015-08-18 01:54:40 UTC) #4

ppi

5 years, 4 months ago (2015-08-18 09:51:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
91530d5e330134c9cbe90aff9ddf990b50a1bb75 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages