Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1296243002: Revert of Add a short term solution to fix OSX 10.11 system font rendering problems. (Closed)

Created:
5 years, 4 months ago by yurys
Modified:
5 years, 4 months ago
Reviewers:
tkent, keishi, erikchen
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add a short term solution to fix OSX 10.11 system font rendering problems. (patchset #2 id:20001 of https://codereview.chromium.org/1284993004/ ) Reason for revert: Newly added test has been failing since its introduction http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&showExpectations=true&tests=FontFamilyMatcherMacTest.YosemiteFontWeights Original issue's description: > Add a short term solution to fix OSX 10.11 system font rendering problems. > > I landed a CL (https://codereview.chromium.org/1276003003/) which fixes system > font problems on OSX 10.9 and OSX 10.10. The CL also fixed MatchNSFontFamily() > to correctly return the system font on 10.11, but this causes glyph rendering > problems. In the short term, I'm adding logic to MatchNSFontFamily() to return > nil on 10.11, which was the original behavior before I landed that CL. > > BUG=521034 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200618 TBR=tkent@chromium.org,keishi@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521034 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M Source/platform/fonts/mac/FontFamilyMatcherMac.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.mm View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
Created Revert of Add a short term solution to fix OSX 10.11 system font rendering ...
5 years, 4 months ago (2015-08-17 15:41:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296243002/1
5 years, 4 months ago (2015-08-17 15:41:26 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 15:41:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200646

Powered by Google App Engine
This is Rietveld 408576698