Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: PRESUBMIT.py

Issue 1296233004: Disable GitBranchCheck on commit presubmit (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-compiler-rt@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d81168ea093e686303f8e98984ffae2bee24308e..a360bb3a87aaf2b9068ede1b9570fbcf2bbb2b4d 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -36,9 +36,6 @@ def _CommonChecks(input_api, output_api):
results.extend(input_api.canned_checks.PanProjectChecks(
input_api, output_api, project_name='Native Client',
excluded_paths=tuple(EXCLUDE_PROJECT_CHECKS_DIRS)))
- branch_warning = CheckGitBranch()
- if branch_warning:
- results.append(output_api.PresubmitPromptWarning(branch_warning))
return results
def CheckChangeOnUpload(input_api, output_api):
@@ -49,6 +46,9 @@ def CheckChangeOnUpload(input_api, output_api):
"""
report = []
report.extend(_CommonChecks(input_api, output_api))
+ branch_warning = CheckGitBranch()
+ if branch_warning:
+ report.append(output_api.PresubmitPromptWarning(branch_warning))
return report
def CheckChangeOnCommit(input_api, output_api):
@@ -59,7 +59,7 @@ def CheckChangeOnCommit(input_api, output_api):
output_api: the limited set of output modules allowed in presubmit.
"""
report = []
- report.extend(CheckChangeOnUpload(input_api, output_api))
+ report.extend(_CommonChecks(input_api, output_api))
return report
def GetPreferredTrySlaves(project, change):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698