cc: Chromify resource_update_queue

cc: Chromify resource_update_queue


BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189530

[alexst (slow to review), 2013-03-20 19:31:08]

moar chrome

[alexst (slow to review), 2013-03-20 19:31:08]

moar chrome

[jamesr, 2013-03-20 19:59:30]

https://codereview.chromium.org/12962007/diff/2001/cc/resources/resource_upda...
File cc/resources/resource_update_queue.cc (right):

https://codereview.chromium.org/12962007/diff/2001/cc/resources/resource_upda...
cc/resources/resource_update_queue.cc:64: copy_entries_.size();
.empty() would be slightly better, I think

https://codereview.chromium.org/12962007/diff/2001/cc/resources/resource_upda...
File cc/resources/resource_update_queue.h (right):

https://codereview.chromium.org/12962007/diff/2001/cc/resources/resource_upda...
cc/resources/resource_update_queue.h:23: void
AppendCopy(TextureCopier::Parameters FIXMENAME);
FIXMENAME

https://codereview.chromium.org/12962007/diff/2001/webkit/compositor_bindings...
File webkit/compositor_bindings/web_external_texture_layer_impl.cc (right):

https://codereview.chromium.org/12962007/diff/2001/webkit/compositor_bindings...
webkit/compositor_bindings/web_external_texture_layer_impl.cc:97: }  //
namespace webkit             a
looks like a bad edit here

[alexst (slow to review), 2013-03-20 20:10:38]

New patch

https://codereview.chromium.org/12962007/diff/2001/cc/resources/resource_upda...
File cc/resources/resource_update_queue.h (right):

https://codereview.chromium.org/12962007/diff/2001/cc/resources/resource_upda...
cc/resources/resource_update_queue.h:23: void
AppendCopy(TextureCopier::Parameters FIXMENAME);
On 2013/03/20 19:59:30, jamesr wrote:
> FIXMENAME

OKAY :)

[jamesr, 2013-03-20 20:22:57]

lgtm

[commit-bot: I haz the power, 2013-03-20 20:25:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/12962007/9001

[commit-bot: I haz the power, 2013-03-20 22:00:53]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-03-20 22:14:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/12962007/9001

[commit-bot: I haz the power, 2013-03-20 22:14:19]

Failed to apply patch for cc/resources/prioritized_resource_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/resources/prioritized_resource_unittest.cc
  Hunk #1 FAILED at 620.
  1 out of 1 hunk FAILED -- saving rejects to file
cc/resources/prioritized_resource_unittest.cc.rej

Patch:       cc/resources/prioritized_resource_unittest.cc
Index: cc/resources/prioritized_resource_unittest.cc
diff --git a/cc/resources/prioritized_resource_unittest.cc
b/cc/resources/prioritized_resource_unittest.cc
index
8fe37360a8c86d534a4f47b9e75ef1cd82606717..249577d27a4607717e4dcfe37c4325d791310ed7
100644
--- a/cc/resources/prioritized_resource_unittest.cc
+++ b/cc/resources/prioritized_resource_unittest.cc
@@ -620,24 +620,24 @@ TEST_F(PrioritizedResourceTest,
clearUploadsToEvictedResources)
     for (size_t i = 0; i < maxTextures; ++i) {
         const ResourceUpdate upload = ResourceUpdate::Create(
             textures[i].get(), NULL, gfx::Rect(), gfx::Rect(),
gfx::Vector2d());
-        queue.appendFullUpload(upload);
+        queue.AppendFullUpload(upload);
     }
 
     // Make sure that we have backings for all of the textures.
     for (size_t i = 0; i < maxTextures; ++i)
         EXPECT_TRUE(textures[i]->have_backing_texture());
 
-    queue.clearUploadsToEvictedResources();
-    EXPECT_EQ(4, queue.fullUploadSize());
+    queue.ClearUploadsToEvictedResources();
+    EXPECT_EQ(4, queue.FullUploadSize());
 
     resourceManager->reduceMemoryOnImplThread(
         texturesMemorySize(1), PriorityCalculator::AllowEverythingCutoff(),
resourceProvider());
-    queue.clearUploadsToEvictedResources();
-    EXPECT_EQ(1, queue.fullUploadSize());
+    queue.ClearUploadsToEvictedResources();
+    EXPECT_EQ(1, queue.FullUploadSize());
 
     resourceManager->reduceMemoryOnImplThread(0, 
PriorityCalculator::AllowEverythingCutoff(), resourceProvider());
-    queue.clearUploadsToEvictedResources();
-    EXPECT_EQ(0, queue.fullUploadSize());
+    queue.ClearUploadsToEvictedResources();
+    EXPECT_EQ(0, queue.FullUploadSize());
 
 }

[commit-bot: I haz the power, 2013-03-20 22:43:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/12962007/15002

[commit-bot: I haz the power, 2013-03-21 05:40:50]

Change committed as 189530