Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1296183004: Try again to put SkXfermode_opts in SK_OPTS_NS (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Try again to put SkXfermode_opts in SK_OPTS_NS Remember failed attempt https://codereview.chromium.org/1286093004/ ? I think this one is simpler and safer and even technically legal C++. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/08f9234eaafcda33ebf5e74ec27ca72f4abda4fb

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/core/SkOpts.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkOpts_neon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkOpts_ssse3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkXfermode_opts.h View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296183004/20001
5 years, 4 months ago (2015-08-18 19:12:21 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-18 19:14:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 19:18:50 UTC) #6
djsollen
lgtm
5 years, 4 months ago (2015-08-18 19:22:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296183004/20001
5 years, 4 months ago (2015-08-18 19:23:04 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 19:23:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/08f9234eaafcda33ebf5e74ec27ca72f4abda4fb

Powered by Google App Engine
This is Rietveld 408576698