Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 12961009: Make webkit_media.gyp depend on cc.gyp (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Make webkit_media.gyp depend on cc.gyp Since webkit/media creates cc::VideoLayer objects and implements the cc::VideoFrameProvider interface, it should depend on the cc library. R=jamesr BUG=196810 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webkit/media/webkit_media.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danakj
7 years, 9 months ago (2013-03-25 23:18:32 UTC) #1
jamesr
lgtm
7 years, 9 months ago (2013-03-25 23:26:11 UTC) #2
danakj
7 years, 9 months ago (2013-03-26 00:14:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r190515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698