Allow more options for setting boolean flag values in SkFlags.

Allow more options for setting boolean flag values in SkFlags.

Now booleans can be set using
--boolean=true or --boolean true (as well as other options).

Committed: https://code.google.com/p/skia/source/detail?r=8285

[reed1, 2013-03-20 20:09:40]

https://codereview.chromium.org/12961003/diff/2001/tools/SkFlags.h
File tools/SkFlags.h (right):

https://codereview.chromium.org/12961003/diff/2001/tools/SkFlags.h#newcode46
tools/SkFlags.h:46: *  The helpString will be printed if the help flag (-h or
-help) is used.
do you mean --help or -help?

https://codereview.chromium.org/12961003/diff/2001/tools/SkFlags.h#newcode241
tools/SkFlags.h:241: static bool ParseBoolArg(const char* string, bool* result)
{
Is it cleaner to use a small table of strings for these, instead of explicit
||s?

[scroggo, 2013-03-20 21:12:05]

https://codereview.chromium.org/12961003/diff/2001/tools/SkFlags.h
File tools/SkFlags.h (right):

https://codereview.chromium.org/12961003/diff/2001/tools/SkFlags.h#newcode46
tools/SkFlags.h:46: *  The helpString will be printed if the help flag (-h or
-help) is used.
On 2013/03/20 20:09:41, reed1 wrote:
> do you mean --help or -help?

In reality, I mean --help or -help or -h or --h. For simplicity, I included only
the ones that are standard (two dashes for multiple characters, one for single
characters).

https://codereview.chromium.org/12961003/diff/2001/tools/SkFlags.h#newcode241
tools/SkFlags.h:241: static bool ParseBoolArg(const char* string, bool* result)
{
On 2013/03/20 20:09:41, reed1 wrote:
> Is it cleaner to use a small table of strings for these, instead of explicit
> ||s?

Done.

[reed1, 2013-03-20 21:13:03]

lgtm

I vote not to support -word, but only -w

[scroggo, 2013-03-21 13:11:08]

Committed patchset #2 manually as r8285 (presubmit successful).