Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: chrome/browser/ui/libgtk2ui/BUILD.gn

Issue 1296043003: libgtk2ui should only add the cups config if use_cups is true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(is_linux, "This file should only be referenced on Linux") 5 assert(is_linux, "This file should only be referenced on Linux")
6 6
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 8
9 component("libgtk2ui") { 9 component("libgtk2ui") {
10 sources = [ 10 sources = [
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 if (use_gconf) { 58 if (use_gconf) {
59 sources += [ 59 sources += [
60 "gconf_listener.cc", 60 "gconf_listener.cc",
61 "gconf_listener.h", 61 "gconf_listener.h",
62 ] 62 ]
63 } 63 }
64 defines = [ "LIBGTK2UI_IMPLEMENTATION" ] 64 defines = [ "LIBGTK2UI_IMPLEMENTATION" ]
65 65
66 configs += [ 66 configs += [
67 "//build/config/linux:gconf", 67 "//build/config/linux:gconf",
68 "//printing:cups",
69 ] 68 ]
70 69
70 if (use_cups) {
71 configs += [
72 "//printing:cups",
73 ]
74 }
75
71 # GTK2 pulls pangoft2 as dependency, and pangoft2 depends on harfbuzz. 76 # GTK2 pulls pangoft2 as dependency, and pangoft2 depends on harfbuzz.
72 # To avoid missing indirectly referenced harfbuzz symbols from pango, 77 # To avoid missing indirectly referenced harfbuzz symbols from pango,
73 # some hack is required when bundled harfbuzz is used and component build is 78 # some hack is required when bundled harfbuzz is used and component build is
74 # disabled. 79 # disabled.
75 # See crbug.com/462689 for details. 80 # See crbug.com/462689 for details.
76 all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ] 81 all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ]
77 82
78 # gn orders flags on a target before flags from configs. The default config 83 # gn orders flags on a target before flags from configs. The default config
79 # adds -Wall, and these flags have to be after -Wall -- so they need to come 84 # adds -Wall, and these flags have to be after -Wall -- so they need to come
80 # from a config and can't be on the target directly. 85 # from a config and can't be on the target directly.
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 "//ui/events:events_base", 123 "//ui/events:events_base",
119 "//ui/gfx", 124 "//ui/gfx",
120 "//ui/gfx/x", 125 "//ui/gfx/x",
121 "//ui/native_theme", 126 "//ui/native_theme",
122 "//ui/resources", 127 "//ui/resources",
123 "//ui/shell_dialogs", 128 "//ui/shell_dialogs",
124 "//ui/strings", 129 "//ui/strings",
125 "//ui/views", 130 "//ui/views",
126 ] 131 ]
127 } 132 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698