Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1296033002: Fix re-layout logic in LayoutScrollbar::updateScrollbarParts. (Closed)

Created:
5 years, 4 months ago by skobes
Modified:
5 years, 4 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix re-layout logic in LayoutScrollbar::updateScrollbarParts. When an iframe's custom scrollbar changes its thickness, it is the LayoutView within the iframe that should be marked for relayout, not the LayoutIFrame. BUG=512914 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200694

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
A LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutScrollbar.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutScrollbar.cpp View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
skobes
5 years, 4 months ago (2015-08-15 06:26:45 UTC) #2
chrishtr
I'm out the next week, passing on the review.
5 years, 4 months ago (2015-08-15 14:30:38 UTC) #4
Xianzhu
lgtm https://codereview.chromium.org/1296033002/diff/1/LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html File LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html (right): https://codereview.chromium.org/1296033002/diff/1/LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html#newcode12 LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html:12: <iframe width=800 height=600 src="resources/empty.html"></iframe> Nit: Would srcdoc="" work ...
5 years, 4 months ago (2015-08-17 16:17:06 UTC) #5
skobes
https://codereview.chromium.org/1296033002/diff/1/LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html File LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html (right): https://codereview.chromium.org/1296033002/diff/1/LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html#newcode12 LayoutTests/scrollbars/custom-scrollbar-enable-changes-thickness-with-iframe.html:12: <iframe width=800 height=600 src="resources/empty.html"></iframe> On 2015/08/17 16:17:05, Xianzhu wrote: ...
5 years, 4 months ago (2015-08-17 20:39:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296033002/20001
5 years, 4 months ago (2015-08-17 20:39:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94249)
5 years, 4 months ago (2015-08-17 22:26:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296033002/20001
5 years, 4 months ago (2015-08-17 22:27:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99311)
5 years, 4 months ago (2015-08-18 00:49:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296033002/20001
5 years, 4 months ago (2015-08-18 00:50:31 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 04:33:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200694

Powered by Google App Engine
This is Rietveld 408576698