Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296013002: Devtools [LayoutEditor]: Support an editing of ems/rems/percentage (Closed)

Created:
5 years, 4 months ago by sergeyv
Modified:
5 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools [LayoutEditor]: Support an editing of ems/rems/percentage BUG=501896 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200689

Patch Set 1 #

Patch Set 2 : Add a comment about the hack #

Total comments: 4

Patch Set 3 : Fix m_factor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
M Source/core/inspector/LayoutEditor.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 1 2 5 chunks +34 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sergeyv
5 years, 4 months ago (2015-08-15 00:06:27 UTC) #2
dgozman
https://codereview.chromium.org/1296013002/diff/20001/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1296013002/diff/20001/Source/core/inspector/LayoutEditor.cpp#newcode226 Source/core/inspector/LayoutEditor.cpp:226: m_factor = 10; Let's try with offsetParent. https://codereview.chromium.org/1296013002/diff/20001/Source/core/inspector/LayoutEditor.cpp#newcode240 Source/core/inspector/LayoutEditor.cpp:240: ...
5 years, 4 months ago (2015-08-15 00:33:48 UTC) #3
sergeyv
https://codereview.chromium.org/1296013002/diff/20001/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1296013002/diff/20001/Source/core/inspector/LayoutEditor.cpp#newcode226 Source/core/inspector/LayoutEditor.cpp:226: m_factor = 10; On 2015/08/15 00:33:47, dgozman wrote: > ...
5 years, 4 months ago (2015-08-17 23:52:18 UTC) #4
pfeldman
lgtm
5 years, 4 months ago (2015-08-17 23:53:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296013002/40001
5 years, 4 months ago (2015-08-17 23:58:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99432)
5 years, 4 months ago (2015-08-18 02:28:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296013002/40001
5 years, 4 months ago (2015-08-18 02:53:33 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 04:23:39 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200689

Powered by Google App Engine
This is Rietveld 408576698