Add new interactive ui test of spoken feedback.

Add new interactive ui test of spoken feedback.

Relands https://src.chromium.org/viewvc/chrome?view=rev&revision=244482.

This is probably too brittle, but I think that's okay at first. As we
add more tests, we should ensure that they don't fail when people make
ordinary, safe changes to the browser.

BUG=339902
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248307

[Peter Lundblad, 2014-01-10 18:40:51]

lgtm

Awesome!  Would be good to intercept the BrailleController and make sure braille
basically works as well, but I can add that afterwards if you want.

//Peter

https://codereview.chromium.org/129593003/diff/1/chrome/browser/chromeos/acce...
File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
(right):

https://codereview.chromium.org/129593003/diff/1/chrome/browser/chromeos/acce...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:179:
EXPECT_EQ("chrome vox spoken feedback is ready", monitor.GetNextUtterance());
Can we have this string as constant (or perhpas a methods that checks that
spoken feedback is not enabled, enables it and waits for the utterance? That'd
make the essense of the test easier to grasp getting rid of some bilerplate.

[dmazzoni, 2014-01-13 09:21:15]

https://codereview.chromium.org/129593003/diff/1/chrome/browser/chromeos/acce...
File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
(right):

https://codereview.chromium.org/129593003/diff/1/chrome/browser/chromeos/acce...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:179:
EXPECT_EQ("chrome vox spoken feedback is ready", monitor.GetNextUtterance());
On 2014/01/10 18:40:51, Peter Lundblad wrote:
> Can we have this string as constant (or perhpas a methods that checks that
> spoken feedback is not enabled, enables it and waits for the utterance? That'd
> make the essense of the test easier to grasp getting rid of some bilerplate.

Good idea. I made it a constant for now, we can refactor more as we add more
tests.

[commit-bot: I haz the power, 2014-01-13 09:21:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/129593003/110001

[commit-bot: I haz the power, 2014-01-13 10:58:59]

Change committed as 244482

[Cait (Slow), 2014-01-13 16:59:11]

A revert of this CL has been created in
https://codereview.chromium.org/137023002/ by caitkp@chromium.org.

The reason for reverting is: Breaking interactive_ui_tests on tree.

[Peter Lundblad, 2014-01-31 20:46:06]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-01-31 20:48:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/129593003/650002

[commit-bot: I haz the power, 2014-01-31 21:22:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/129593003/650002

[commit-bot: I haz the power, 2014-02-01 00:03:03]

Change committed as 248307

[commit-bot: I haz the power, 2014-02-01 00:03:12]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-01 00:03:12]

CQ bit was unchecked on CL. Ignoring.